<html>
<head><meta charset="utf-8"><title>rust-lang/team Reviewers · project leads (public) · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/index.html">project leads (public)</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html">rust-lang/team Reviewers</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="188494222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188494222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188494222">(Feb 18 2020 at 21:40)</a>:</h4>
<p>Hey, in getting more people to sign up and use <code>rust-lang/team</code>, I've seen more and more people ask about who they should ping to merge the changes, because they'll ping their team leads who approved the PR, but they often aren't the same people who can merge it. Can we document who to ping? Right I think it's been defacto core (mainly pietro, &amp; niko afaik), and could we increase the bus factor of people with merge permissions?</p>



<a name="188494271"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188494271" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188494271">(Feb 18 2020 at 21:41)</a>:</h4>
<p>hmm the people with review rights should all have merge permissions, no?</p>



<a name="188494280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188494280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188494280">(Feb 18 2020 at 21:41)</a>:</h4>
<p>Ideally maybe we could have a bot that merges when team lead(s) approve.</p>



<a name="188494314"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188494314" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188494314">(Feb 18 2020 at 21:41)</a>:</h4>
<p>maybe I'm out of touch with the current setup of other teams.</p>



<a name="188494385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188494385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188494385">(Feb 18 2020 at 21:42)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> I mean the number of people who review <code>rust-lang/team</code> repo specifically, sorry if that was unclear.</p>



<a name="188494436"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188494436" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188494436">(Feb 18 2020 at 21:43)</a>:</h4>
<p>oh oh</p>



<a name="188494444"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188494444" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188494444">(Feb 18 2020 at 21:43)</a>:</h4>
<p>sorry i get it now</p>



<a name="188495278"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188495278" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188495278">(Feb 18 2020 at 21:52)</a>:</h4>
<p>I think just core is fine for now. Once team lead approves (who realistically is likely at least somewhat on core).</p>



<a name="188495405"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188495405" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188495405">(Feb 18 2020 at 21:53)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Not working group leads, which are the larger amount of traffic on team.</p>



<a name="188495654"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188495654" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188495654">(Feb 18 2020 at 21:56)</a>:</h4>
<p>I think the majority of traffic is from formation of the ice breaker and code cleanup WGs, and that'll (I suspect) die down to near-zero within days.</p>



<a name="188495690"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188495690" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188495690">(Feb 18 2020 at 21:56)</a>:</h4>
<p>I personally believe that there is not enough reason to write a bot, and I would not be entirely comfortable with giving a bot that kind of power.</p>



<a name="188497282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497282">(Feb 18 2020 at 22:19)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Well my preferred solution would be to just add more people who can merge. I don't think leaving it to core is any kind of solution, when core is already so overwhelmed. There are issues old enough to walk and talk blocked on core.</p>



<a name="188497437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497437">(Feb 18 2020 at 22:21)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> the team repo is critical, because anyone with unconditional write access to it can escalate permissions up to core and infra-admins</p>



<a name="188497451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497451">(Feb 18 2020 at 22:21)</a>:</h4>
<p>I had an idea to ease the problem, but I didn't have time to implement it yet</p>



<a name="188497542"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497542" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497542">(Feb 18 2020 at 22:22)</a>:</h4>
<p>basically what we want is:</p>
<ul>
<li>team leads can add new members to their team at will</li>
<li>any other change (including permissions) requires approval from the core team, which is just a security review</li>
</ul>



<a name="188497613"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497613" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497613">(Feb 18 2020 at 22:23)</a>:</h4>
<p>so my idea was to split the team files into two files, like:</p>
<div class="codehilite"><pre><span></span>teams/infra/people.toml
teams/infra/meta.toml
</pre></div>


<p>and use github's code owners feature to make the relevant team leads and core the "code owners" of their team, and just core the "code owners" of any other file in the repo</p>



<a name="188497622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497622">(Feb 18 2020 at 22:23)</a>:</h4>
<p>and configure github to require approval from code owners to allow merging changes</p>



<a name="188497749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497749">(Feb 18 2020 at 22:25)</a>:</h4>
<p><em>if</em> github works the way we want (any change other than to a <code>people.toml</code> requires core team approval, even if the other file changed is a <code>people.toml</code>), that would allow us to safely give write access to all team and wg leads, while being assured that they can't escalate privileges</p>



<a name="188497773"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497773" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497773">(Feb 18 2020 at 22:25)</a>:</h4>
<p>this needs more testing in a dummy repo to make sure the feature works the way we expect (I don't have much experience with it, I mostly just read the docs) and then the actual implementation work</p>



<a name="188497886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497886">(Feb 18 2020 at 22:27)</a>:</h4>
<p>let me know if something is not clear, and I'll try explain it better when it's not late here :)</p>



<a name="188497893"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497893" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497893">(Feb 18 2020 at 22:27)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I understand it's critical, I still think it's worth the potential risk.</p>



<a name="188497965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497965">(Feb 18 2020 at 22:28)</a>:</h4>
<p>I absolutely don't want any wg lead to be able to redirect <a href="mailto:admin@rust-lang.org" title="mailto:admin@rust-lang.org">admin@rust-lang.org</a> emails, that would be <em>horrible</em></p>



<a name="188497979"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497979" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497979">(Feb 18 2020 at 22:28)</a>:</h4>
<p>Like what you said you proposed is very complicated compared to just trusting someone.</p>



<a name="188497986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497986">(Feb 18 2020 at 22:28)</a>:</h4>
<p>it's not just trust in the leads themselves, but also in their security practices</p>



<a name="188497992"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188497992" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188497992">(Feb 18 2020 at 22:28)</a>:</h4>
<p>and limiting the attack surface of the project as a whole</p>



<a name="188498128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188498128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188498128">(Feb 18 2020 at 22:30)</a>:</h4>
<p>I'd love to fix the problem, but the solution needs to avoid allowing leads to escalate privileges</p>



<a name="188498196"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188498196" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188498196">(Feb 18 2020 at 22:31)</a>:</h4>
<p>if you have better ideas I'm all ears :D</p>



<a name="188498513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188498513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188498513">(Feb 18 2020 at 22:36)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> Well we could have a train model, similar to the website or rust with master as a protected branch.</p>



<a name="188498622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188498622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188498622">(Feb 18 2020 at 22:38)</a>:</h4>
<p>Have a new branch called <code>pending</code>, and leads can merge whatever into that, and then someone from core commits a block of changes at once instead of each one individually.</p>



<a name="188498681"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188498681" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188498681">(Feb 18 2020 at 22:39)</a>:</h4>
<p>I'm not clear how that is better from a lot of small PRs getting merged as a batch</p>



<a name="188498725"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188498725" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188498725">(Feb 18 2020 at 22:40)</a>:</h4>
<p><span class="user-mention" data-user-id="224471">@Lokathor</span> What you said is what I proposed so I'm not sure what you mean.</p>



<a name="188498839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188498839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188498839">(Feb 18 2020 at 22:41)</a>:</h4>
<p>I mean I don't see how merging 5PRs to a pending branch and then merging that branch to master once is better than just merging 5PRs each to master</p>



<a name="188498939"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188498939" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188498939">(Feb 18 2020 at 22:42)</a>:</h4>
<p><span class="user-mention" data-user-id="224471">@Lokathor</span> Because any lead could merge the 5 PRs, and then someone from core only has to merge and review one PR consisting of 5 commits.</p>



<a name="188499103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188499103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188499103">(Feb 18 2020 at 22:45)</a>:</h4>
<p>It reduces the number of tasks required by someone in core from 5 to 1.</p>



<a name="188499467"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188499467" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188499467">(Feb 18 2020 at 22:49)</a>:</h4>
<p>hmm</p>



<a name="188499544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188499544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188499544">(Feb 18 2020 at 22:50)</a>:</h4>
<p>the downside of that would be increased friction when someone from core wants to merge just a single PR</p>



<a name="188499567"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188499567" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188499567">(Feb 18 2020 at 22:50)</a>:</h4>
<p>as we would have to first merge into pending and then merge pending into master</p>



<a name="188499614"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188499614" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188499614">(Feb 18 2020 at 22:51)</a>:</h4>
<p>potentially having to review other changes in pending in the meantime, even though we only wanted to merge a single PR</p>



<a name="188499634"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188499634" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188499634">(Feb 18 2020 at 22:52)</a>:</h4>
<p>the way I see it we only have this problem if there is a large influx of new members</p>



<a name="188499711"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188499711" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188499711">(Feb 18 2020 at 22:52)</a>:</h4>
<p>so we could create tooling to easily rollup PRs, and the lead of a icebreakers crew could rollup the tens of PRs related to that into a single one for core to review</p>



<a name="188499717"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188499717" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188499717">(Feb 18 2020 at 22:52)</a>:</h4>
<p>like we've been doing manually these days</p>



<a name="188500035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500035">(Feb 18 2020 at 22:57)</a>:</h4>
<p>I feel like the increased friction is quite minimal, it's rare that any change to <code>rust-lang/team</code> is urgent, and it's fine if some of the time it's a bit harder for core, when it's easier for everyone else most of the time.</p>



<a name="188500466"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500466" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500466">(Feb 18 2020 at 23:03)</a>:</h4>
<p>I don't feel like tooling will solve this problem, that's adding more dependencies, as the tooling needs to be maintained.</p>



<a name="188500497"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500497" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500497">(Feb 18 2020 at 23:03)</a>:</h4>
<p>to be clear, I think if someone wants to create batch PRs then that'd be fine IMO, though it may not be that much easier than just individual PR review anyway</p>



<a name="188500692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500692">(Feb 18 2020 at 23:06)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Well the main part of that is having master protected, and giving leads write permissions, which someone can't just do, it has be someone on core.</p>



<a name="188500709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500709">(Feb 18 2020 at 23:07)</a>:</h4>
<p>Just making batch PRs wouldn't make any sense.</p>



<a name="188500719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500719">(Feb 18 2020 at 23:07)</a>:</h4>
<p>batch PRs are equivalent to the staging branch?</p>



<a name="188500740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500740">(Feb 18 2020 at 23:07)</a>:</h4>
<p>I'm not opposed to having a staging branch that is periodically merged into master by someone from core, via a PR that pings someone on core</p>



<a name="188500753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500753">(Feb 18 2020 at 23:07)</a>:</h4>
<p>presuming we can do that in github without granting everyone write permissions</p>



<a name="188500754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500754">(Feb 18 2020 at 23:08)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Yes equivalent to that.</p>



<a name="188500856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188500856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188500856">(Feb 18 2020 at 23:08)</a>:</h4>
<p>Well I believe we already have that situation on other repos, e.g. I can write to the <code>master</code> branch of the website but not <code>deploy</code>.</p>



<a name="188502156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188502156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188502156">(Feb 18 2020 at 23:29)</a>:</h4>
<p>hm, well, something to think about. I don't personally see current situation as a big problem.</p>



<a name="188504886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188504886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188504886">(Feb 19 2020 at 00:14)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I'm not saying it's a big problem. I don't know if we have any really big problems, we have a lot of little ones.</p>



<a name="188504994"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/188504994" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#188504994">(Feb 19 2020 at 00:16)</a>:</h4>
<p>Sure. I guess something we could fix. Probably won't have time soon though :)</p>



<a name="191471931"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217588-project%20leads%20%28public%29/topic/rust-lang/team%20Reviewers/near/191471931" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> spacekookie <a href="https://rust-lang.github.io/zulip_archive/stream/217588-project-leads-(public)/topic/rust-lang.2Fteam.20Reviewers.html#191471931">(Mar 23 2020 at 13:25)</a>:</h4>
<p>(deleted)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>